Comment in line 7 was from tonight. No idea, why Gerrit didn’t publish it.
2 comments:
Patch Set #1, Line 7: mb/asrock/e350m1/buildOpts.c: Fix AGESA_VERSION_STRING
Yes, and they should also be understandable. *Fix* is just too general to get anything out of the short log. Adding the version number adds some perspective.
mb/asrock/e350m1: Set AGESA version to 1.1.0.3
mb/asrock/e350m1: Fix AGESA_VERSION_STRING to 1.1.0.3
Patch Set #1, Line 10: Change it so that it matches the other AGESA f14 boards in the tree.
Well, I voted +2 for it and think it is already okay. Feel free to merge it.
Angel, I am sorry for the frustration. I suggested the improvement, but still voted +1, so you could have resolved the commit and merged despite the comments. I am fine to agree to disagree.
To view, visit change 41621. To unsubscribe, or for help writing mail filters, visit settings.