9 comments:
Patch Set #8, Line 10: firmware protection
What does this refer to? Is the IFD fully unlocked? Are all protected ranges unset? Does it not use Boot Guard?
EC firmware is contained within the system SPI flash, and so a blob of
EC firmware must be injected to a defined location during image build.
I would suggest using a fmap to define this location. I was suggested the same for a laptop with the same problem.
I'd suggest listing what works/does not work/is untested.
Patch Set #8, Line 23: /* Enable function 5 (PS/2 AUX) */
I'm not sure? There's no superio on the board, just the EC, and the EC also handles PS/2. […]
Some ECs have a SuperIO-like part. See ec/roda/it8518 for an example.
Patch Set #8, Line 43: CHIP_NAME("51NB EC")
Not sure if all the 51nb devices use the same EC. I'd suggest specifying the EC model (NPCE9...) so that there isn't a name conflict if a 2nd 51nb EC were to be added.
Yes, this would imply moving everything in a subfolder and updating all the paths.
Patch Set #8, Line 43: 0x00200000
No
Is that the beginning of the BIOS region? Some other different Nuvoton EC I have has the firmware at the same location.
Patch Set #8, Line 20: #define SETUP_COMMAND 0x4e
No, this is (as far as I can tell) specific to the EC part.
I recall seeing 0x4e/0x4f somewhere else... These are the IO addresses the SuperIO part of the EC uses. These are sometimes selectable (most SuperIOs use 0x2e/0x2f).
I'd say this is mainboard-specific.
File src/mainboard/51nb/x210/acpi/ec.asl:
Patch Set #8, Line 126: Device (BAT)
Maybe this could go in acpi/battery.asl
File src/mainboard/51nb/x210/mainboard.c:
Patch Set #8, Line 57: /* Route 0x4e/4f to LPC */
Ah, this is what I recall 0x4e/0x4f from.
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.