8 comments:
File src/mainboard/51nb/x210/Kconfig:
Patch Set #28, Line 12: select MAINBOARD_USES_FSP2_0
Not needed, since this is selected by the SOC
Done
config MAINBOARD_VENDOR
string
default "51NB"
Not needed, since it is set by `src/mainboard/51nb/Kconfig`
Done
config DEVICETREE
string
default "devicetree.cb"
Not needed, since this is the default name
Done
config CPU_MICROCODE_CBFS_LEN
hex
default 0x18000
config CPU_MICROCODE_CBFS_LOC
hex
default 0xFFE115A0
only needed if using FSP-T, which may be discouraged if not tested.
Done
File src/mainboard/51nb/x210/board.fmd:
Patch Set #28, Line 12: CONSOLE@0x60200 0x20000
Afaik there is no alignment requirements on this region, but for simplicity of erasing this region i […]
Done
EC@0x0 0x10000
RW_MRC_CACHE@0x10000 0x10000
SMMSTORE@0x20000 0x40000
FMAP@0x60000 0x200
CONSOLE@0x60200 0x20000
COREBOOT(CBFS)@0x80200 0x57FE00
You can skip specifying offsets of most of the regions and also the size of the COREBOOT region if y […]
Done
File src/mainboard/51nb/x210/romstage.c:
Patch Set #28, Line 28: /* Rcomp resistor */
Not strictly required as the function is static and called in a way that it can't be NULL
Done
Patch Set #28, Line 36: /* Rcomp target */
Not strictly required as the function is static and called in a way that it can't be NULL
Done
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.