Looks great overall! The nits about pure cosmetic changes can probably be ignored for now. The copyright headers will need to be removed to avoid conflicting with the CB:39605 patch chain.

Patch set 1:Code-Review -1

View Change

7 comments:

• File src/mainboard/ocp/tiogapass/Kconfig:

  • Patch Set #1, Line 26: select FSP_CAR

    Does this change belong in this patch?

• File src/soc/intel/xeon_sp/bootblock.c:

  • Patch Set #1, Line 22: #include <console/console.h>

    Cosmetic changes should go in another patch.

• File src/soc/intel/xeon_sp/include/soc/iomap.h:

  • Patch Set #1:

    Thanks for fixing the indentation, but purely cosmetic changes should go in another patch.

• File src/soc/intel/xeon_sp/include/soc/pcr_ids.h:

  • Patch Set #1:

    purely cosmetic changes should go in another patch.

• File src/soc/intel/xeon_sp/skx/Makefile.inc:

  • Patch Set #1, Line 5: ## Copyright (C) 2019 - 2020 Facebook Inc

    Get rid of these (as per the CB:39605 patch chain)

• File src/soc/intel/xeon_sp/skx/hob_display.c:

  • Patch Set #1:

    purely cosmetic changes should go in another patch.

• File src/soc/intel/xeon_sp/skx/romstage.c:

  • Patch Set #1, Line 5: * Copyright (C) 2019 - 2020 Facebook Inc

    Get rid of these (as per the CB:39605 patch chain)

To view, visit change 39601. To unsubscribe, or for help writing mail filters, visit settings.