David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39601 )
Change subject: soc/intel/xeon_sp: Refactor code to allow for additional CPUs ......................................................................
Patch Set 1: Code-Review-1
(7 comments)
Looks great overall! The nits about pure cosmetic changes can probably be ignored for now. The copyright headers will need to be removed to avoid conflicting with the CB:39605 patch chain.
https://review.coreboot.org/c/coreboot/+/39601/1/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/39601/1/src/mainboard/ocp/tiogapass... PS1, Line 26: select FSP_CAR Does this change belong in this patch?
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/bootb... File src/soc/intel/xeon_sp/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/bootb... PS1, Line 22: #include <console/console.h> Cosmetic changes should go in another patch.
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/iomap.h:
PS1: Thanks for fixing the indentation, but purely cosmetic changes should go in another patch.
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/pcr_ids.h:
PS1: purely cosmetic changes should go in another patch.
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/skx/M... File src/soc/intel/xeon_sp/skx/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/skx/M... PS1, Line 5: ## Copyright (C) 2019 - 2020 Facebook Inc Get rid of these (as per the CB:39605 patch chain)
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/skx/h... File src/soc/intel/xeon_sp/skx/hob_display.c:
PS1: purely cosmetic changes should go in another patch.
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/skx/r... File src/soc/intel/xeon_sp/skx/romstage.c:
https://review.coreboot.org/c/coreboot/+/39601/1/src/soc/intel/xeon_sp/skx/r... PS1, Line 5: * Copyright (C) 2019 - 2020 Facebook Inc Get rid of these (as per the CB:39605 patch chain)