build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )
Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/31284/7/src/soc/intel/cannonlake/fsp_params....
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31284/7/src/soc/intel/cannonlake/fsp_params....
PS7, Line 38: memcpy(params->SerialIoI2cMode, config->SerialIoI2cMode, CONFIG_SOC_INTEL_I2C_DEV_MAX);
line over 80 characters
https://review.coreboot.org/#/c/31284/7/src/soc/intel/cannonlake/fsp_params....
PS7, Line 39: memcpy(params->SerialIoSpiMode, config->SerialIoGSpiMode, CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX);
line over 80 characters
https://review.coreboot.org/#/c/31284/7/src/soc/intel/cannonlake/fsp_params....
PS7, Line 40: memcpy(params->SerialIoUartMode, config->SerialIoUartMode, SOC_INTEL_CML_UART_DEV_MAX);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib92b660409ab01d70358042b2ed29b8bf9cab26d
Gerrit-Change-Number: 31284
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 Feb 2019 02:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment