Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner.

Patch set 4:Verified +1

View Change

2 comments:

• File src/mainboard/google/herobrine/mainboard.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139619):

    Patch Set #4, Line 61: if (display_init_required()) {

    suspect code indent for conditional statements (8, 24)

• File src/soc/qualcomm/sc7280/display/edp_ctrl.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139619):

    Patch Set #4, Line 863: ret = edp_start_link_train_2(ctrl,dpcd);

    space required after that ',' (ctx:VxV)

To view, visit change 61342. To unsubscribe, or for help writing mail filters, visit settings.