Patch Set 1:

I think some of the static analysis tools are using it for modelling life times. But perhaps we should rename our malloc to something else instead?

I'm not following. free() in this patch is just incorrect as the objects are allocated from bss section -- not malloc.

View Change

1 comment:

To view, visit change 37940. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90659722aaca6ced1e1cbc3db4180b0811205e95
Gerrit-Change-Number: 37940
Gerrit-PatchSet: 1
Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-Comment-Date: Fri, 27 Dec 2019 16:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment