Attention is currently required from: Bao Zheng, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78304?usp=email ) Change subject: amdfwtool: Remove the function's dependency to ctx ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78304/comment/ad6fd89b_0620ed72 : PS4, Line 9: writebody write_body function https://review.coreboot.org/c/coreboot/+/78304/comment/757e2d6f_c37fcb7c : PS4, Line 11: would be good to also mention that the amdfwtool_cleanup calls are removed from write_body, but since write_body now returns to the main function, amdfwtool_cleanup still ends up getting called -- To view, visit https://review.coreboot.org/c/coreboot/+/78304?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I639828498fa45911f430500735e90ddc198b6af5 Gerrit-Change-Number: 78304 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi@gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 29 Feb 2024 21:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment