What I am doing: checking a commit history for F2A85-M (on which this port is based) - https://github.com/coreboot/coreboot/commits/master/src/mainboard/asus/f2a85-m - and carefully applying these commits for A88XM-E. I've done it for "Dec 20, 2019 (b9bd69e) - Oct 27, 2019 (dac4497)", with the exception of ROMCC ones - these require a closer look; just like "Oct 8, 2019 (2f8192b), Fix superio type in devicetree" - need to check what SuperIO that A88XM-E has before doing this. Guess we should do this for all the commits which happened to F2A85-M after your port and therefore are not a part of your port yet. After we do all this and A88XM-E becomes as good as F2A85-M, then it could be merged I guess.

View Change

1 comment:

• File src/mainboard/asus/a88xm-e/acpi/cpstate.asl:

  • Patch Set #16, Line 26: Processor(C

    Don't use deprecated 'Processor()'. Please Use 'Device()' instead […]

    Done.

To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.