Attention is currently required from: Nico Huber, Angel Pons.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47107 )
Change subject: option.h: Introduce {get,set}_int_option() functions
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/47107/comment/976b6632_6218382f
PS6, Line 29: set_option
should this print an error on failure to set the CMOS option? Or use an assertion?
https://review.coreboot.org/c/coreboot/+/47107/comment/18c6f00f_be631ec8
PS6, Line 35: return get_option(&value, name) == CB_SUCCESS ? value : fallback;
should this print an error on failure to set the CMOS option? Or use an assertion?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bbc51135216f34518cfd05c3dc90fb68404c1cc
Gerrit-Change-Number: 47107
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 19 Apr 2021 17:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment