Sorry for the revert. Please, split out the functional
changes (e.g. the cpuid stuff around core/thread count)
into their own patch (it's not related to the SMBIOS
update, is it?). This change does a lot of things, and
I haven't spotted anything yet that is *required* for

From the 3.2 spec, core counts and thread counts don't seem to be optional.
The newly added procedure is populating them to comply to one of your previous comment:
" please don't add fields without giving them a reasonable value"

Well, core/thread count are not added by in this change,
so my comment doesn't apply to them. I was mostly refer-
ring to the added fields that were left untouched (at 0)
where 0 isn't a valid value. Sorry for the confusion.

Still, you could fix the cpuid code first, then add SMBIOS
3.2 stuff. I don't see why it would have to be part of the
same commit.

I can remove it from this patch if you require it and set the values to 0. Because the count generated by the code before this upgrade was not accurate, at least not on the GKL Sparky platform.

I know the current code doesn't provide accurate values in
all cases. But in some cases it might. So why would you
want to set it to 0 in all cases?

Also, we are talking about an extension of existing fields.
With less than 256 cores, core_count2 must have the same
value as core_count. Whether or not the value of the latter
is accurate is an orthogonal issue.

View Change

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 5
Gerrit-Owner: Francois Toguo Fotso <>
Gerrit-Reviewer: Francois Toguo Fotso <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Francois Toguo Fotso <>
Gerrit-CC: Lijian Zhao <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-Comment-Date: Fri, 29 Mar 2019 08:59:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment