Attention is currently required from: Johnny Lin, Paul Menzel, Christian Walter, Jingle Hsu, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang@wiwynn.com.

Johnny Lin uploaded patch set #6 to this change.

View Change

mb/ocp/deltalake: Fix SMBIOS type 9 bugs

1. Fix PCIe slot capabilities not being really read from an IIO root
   port device. The Hot-Plug capability of IIO root port cannot be enabled
   due to FSP limitation (v2.1-0.2.2.0), but the code should reflect the
   true capabilities by reading the root port device's CSR.

2. Initialize the characteristics flags to 0 in the for-loop to fix the
   issue of the flags values persists to the next iterations.

Tested=On OCP Delta Lake, dmidecode -t 9 shows expected results.
For example without the fix it shows 'Hot-plug devices are supported' but
in fact it's not:
System Slot Information
        Designation: SSD1_M2_Data_Drive
        Type: x4 PCI Express 3 x4
        Current Usage: Available
        Length: Short
        ID: 1
        Characteristics:
                3.3 V is provided
                PME signal is supported
                Hot-plug devices are supported
        Bus Address: 0000:00:1d.0

With the fix it shows the correct result:
Handle 0x0016, DMI type 9, 19 bytes
System Slot Information
        Designation: SSD1_M2_Data_Drive
        Type: x4 PCI Express 3 x4
        Current Usage: Available
        Length: Short
        ID: 1
        Characteristics:
                3.3 V is provided
                PME signal is supported
        Bus Address: 0000:00:1d.0

Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9
Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com>
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 13 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/58100/6

To view, visit change 58100. To unsubscribe, or for help writing mail filters, visit settings.