Patch Set 1: Code-Review-1

Dug a little into the chipset support for historical Intel
in the tree: Older ICHs implement the bit r/w but mention
to ignore it anyway, because everything goes to PCI. So that
should be fine.

440BX doesn't seem to know it, though :-/ So this can't go
in as is. I'm open for suggestions. What should we do if
16-bit decode isn't possible? Restrict all i/o to 10 bits?
That could brick... Hmmmm, just warn about it? Instead of
skipping the device?

I really don't like to reserve the VGA resources 64 times,
could do that, though.

View Change

1 comment:

To view, visit change 35516. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7a07f069dd54331df79f605c6bcda37882a602d
Gerrit-Change-Number: 35516
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 21 Sep 2019 18:46:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-MessageType: comment