View Change
1 comment:
Commit Message:
Patch Set #1, Line 11:
The new setting values have been from other projects using same I2C
components.
Aren't these settings board-specific?
We just verified that I2C frequency < 400MHz with the new parameters on kohaku. (b:144885961)
As we measured w/o this change, I2C1/I2C4 frequency > 400MHz. So I needed to find new parameters, I got them from other project's than hatch which were using "Elan touchscreen" and "da7219" codec.
To view, visit change 37313. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9614fb39b6e55cb2ce1b0879a9f5204e55002f8d
Gerrit-Change-Number: 37313
Gerrit-PatchSet: 1
Gerrit-Owner: shkim <sh_.kim@samsung.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim@samsung.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: shkim <sh_.kim@samsung.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Tue, 03 Dec 2019 00:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment