4 comments:
File util/amdfwtool/amdfwtool-b.c:
Nit: some indentation issues, which seems odd to me since I didn't see them in the other copy of the file. /shrug
File util/amdfwtool/amdfwtool.c:
Patch Set #39, Line 1086: // Unused values: D
Could we keep the list of unused values - we still have quite a long list of arguments.
printf("-x | --xhci <FILE> Add XHCI blob\n");
printf("-i | --imc <FILE> Add IMC blob\n");
printf("-g | --gec <FILE> Add GEC blob\n");
Any reason not to move more of these options to the config file?
Patch Set #39, Line 1456: exit(1);
Can we add a way to generated a config file with no values? How would someone know currently what the options to add to the config file are?
To view, visit change 42859. To unsubscribe, or for help writing mail filters, visit settings.