Elyes Haouas has uploaded this change for review.

View Change

mb/amd/*/irq_tables.c: Reformate code

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: If6cdf02c56778da67b56afbb71f9f01107f23d2e
---
M src/mainboard/amd/gardenia/irq_tables.c
M src/mainboard/amd/inagua/irq_tables.c
M src/mainboard/amd/olivehill/irq_tables.c
M src/mainboard/amd/parmer/irq_tables.c
M src/mainboard/amd/persimmon/irq_tables.c
M src/mainboard/amd/south_station/irq_tables.c
M src/mainboard/amd/thatcher/irq_tables.c
M src/mainboard/amd/union_station/irq_tables.c
8 files changed, 33 insertions(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/67519/1
diff --git a/src/mainboard/amd/gardenia/irq_tables.c b/src/mainboard/amd/gardenia/irq_tables.c
index 2eefede..e5d576a 100644
--- a/src/mainboard/amd/gardenia/irq_tables.c
+++ b/src/mainboard/amd/gardenia/irq_tables.c
@@ -65,8 +65,7 @@

/* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c
index 4f23994..e5d576a 100644
--- a/src/mainboard/amd/inagua/irq_tables.c
+++ b/src/mainboard/amd/inagua/irq_tables.c
@@ -63,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -78,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);

diff --git a/src/mainboard/amd/olivehill/irq_tables.c b/src/mainboard/amd/olivehill/irq_tables.c
index 4f23994..e5d576a 100644
--- a/src/mainboard/amd/olivehill/irq_tables.c
+++ b/src/mainboard/amd/olivehill/irq_tables.c
@@ -63,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -78,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);

diff --git a/src/mainboard/amd/parmer/irq_tables.c b/src/mainboard/amd/parmer/irq_tables.c
index 4f23994..e5d576a 100644
--- a/src/mainboard/amd/parmer/irq_tables.c
+++ b/src/mainboard/amd/parmer/irq_tables.c
@@ -63,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -78,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);

diff --git a/src/mainboard/amd/persimmon/irq_tables.c b/src/mainboard/amd/persimmon/irq_tables.c
index 85ab57a..e5d576a 100644
--- a/src/mainboard/amd/persimmon/irq_tables.c
+++ b/src/mainboard/amd/persimmon/irq_tables.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <console/console.h>
+#include <commonlib/bsd/helpers.h>
#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
@@ -62,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -77,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);

diff --git a/src/mainboard/amd/south_station/irq_tables.c b/src/mainboard/amd/south_station/irq_tables.c
index 4f23994..e5d576a 100644
--- a/src/mainboard/amd/south_station/irq_tables.c
+++ b/src/mainboard/amd/south_station/irq_tables.c
@@ -63,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -78,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);

diff --git a/src/mainboard/amd/thatcher/irq_tables.c b/src/mainboard/amd/thatcher/irq_tables.c
index 4f23994..e5d576a 100644
--- a/src/mainboard/amd/thatcher/irq_tables.c
+++ b/src/mainboard/amd/thatcher/irq_tables.c
@@ -63,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -78,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);

diff --git a/src/mainboard/amd/union_station/irq_tables.c b/src/mainboard/amd/union_station/irq_tables.c
index 4f23994..e5d576a 100644
--- a/src/mainboard/amd/union_station/irq_tables.c
+++ b/src/mainboard/amd/union_station/irq_tables.c
@@ -63,10 +63,9 @@
pirq_info = (void *)(&pirq->checksum + 1);
slot_num = 0;

- /* pci bridge */
+ /* PCI bridge */
write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4),
- 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0,
- 0);
+ 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
pirq_info++;

slot_num++;
@@ -78,9 +77,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) {
+ if (sum != pirq->checksum)
pirq->checksum = sum;
- }

printk(BIOS_INFO, "%s done.\n", __func__);


To view, visit change 67519. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6cdf02c56778da67b56afbb71f9f01107f23d2e
Gerrit-Change-Number: 67519
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>
Gerrit-MessageType: newchange