Patch Set 10:
(1 comment)
7 comments:
SSPM is a Secure System Power Manager for
power control in secure domain.
Please use the full text width.
Done
Patch Set #10, Line 11: is load
is to load
Done
Patch Set #10, Line 11: SSPM firmware
Is that already in the 3rdparty repository?
https://review.coreboot.org/c/blobs/+/32698
File src/soc/mediatek/mt8183/sspm.c:
Patch Set #10, Line 19: <arch/io.h>
This header file has been renamed. Use "<arch/mmio.h>" instead.
Done
Patch Set #10, Line 35: die("SSPM file not found.");
As the name is in a variable, please print the name in the error message too.
Done
is
Done
/* Memory barrier to ensure that all fw code are loaded
* before we release the reset pin.
*/
Please follow the coding style. […]
Done
To view, visit change 31516. To unsubscribe, or for help writing mail filters, visit settings.