Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7973
-gerrit
commit 5e2ac8074714b62a2cd5a9fb5403f584bc1d5d04 Author: Patrick Georgi patrick@georgi-clan.de Date: Mon Dec 29 19:57:14 2014 +0100
libpayload/PDcurses: avoid NULL deref
Change-Id: I86f1c97858fa3d007c4d4509fac3473c9e2ad2f2 Signed-off-by: Patrick Georgi patrick@georgi-clan.de Found-by: Coverity Scan --- payloads/libpayload/curses/PDCurses-3.4/pdcurses/clear.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/payloads/libpayload/curses/PDCurses-3.4/pdcurses/clear.c b/payloads/libpayload/curses/PDCurses-3.4/pdcurses/clear.c index 0128df5..75426e2 100644 --- a/payloads/libpayload/curses/PDCurses-3.4/pdcurses/clear.c +++ b/payloads/libpayload/curses/PDCurses-3.4/pdcurses/clear.c @@ -86,14 +86,14 @@ int clrtoeol(void)
int wclrtobot(WINDOW *win) { - int savey = win->_cury; - int savex = win->_curx; - PDC_LOG(("wclrtobot() - called\n"));
if (!win) return ERR;
+ int savey = win->_cury; + int savex = win->_curx; + /* should this involve scrolling region somehow ? */
if (win->_cury + 1 < win->_maxy)