26 comments:
File src/mainboard/microtech/etabpro/Kconfig:
Patch Set #4, Line 3: BOARD_INTEL_BASEBOARD_GLKRVP
BOARD_SPECIFIC_OPTIONS
Patch Set #4, Line 4: def_bool n
Enable this:
def_bool y
Patch Set #4, Line 12: select MAINBOARD_HAS_CHROMEOS
No ChromeOS for now.
select DRIVERS_GENERIC_MAX98357A
select DRIVERS_I2C_DA7219
These are for audio chips on chromebooks. Not needed
Patch Set #4, Line 16: select SOC_ESPI
That might not be true.
# config for GLK CHROME EC
select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_ESPI
select VBOOT_LID_SWITCH
select EC_GOOGLE_CHROMEEC_SWITCHES
No ChromeEC here
config VBOOT
select HAS_RECOVERY_MRC_CACHE
select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
Remove this for now.
config CHROMEOS
bool
default y
select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC
No ChromeOS
config VARIANT_DIR
string
default "glkrvp"
Shouldn't be needed
config DEVICETREE
string
default "devicetree.cb"
Is the default value, this can be removed
Patch Set #4, Line 74: Intel_Glkrvp
Hmmmmmmmmmm...
config IS_GLK_RVP_1
bool "Is this RVP1?"
default n
Not applicable
config INCLUDE_NHLT_BLOBS
bool "Include blobs for audio"
select NHLT_DMIC_2CH_16B
select NHLT_DMIC_4CH_16B
select NHLT_MAX98357
Not applicable either.
File src/mainboard/microtech/etabpro/Kconfig.name:
select BOARD_INTEL_BASEBOARD_GLKRVP
select BASEBOARD_GLKRVP_LAPTOP
These can go away
File src/mainboard/microtech/etabpro/Makefile.inc:
Patch Set #4, Line 4: romstage-$(CONFIG_CHROMEOS) += chromeos.c
ChromeOS!
File src/mainboard/microtech/etabpro/boardid.c:
This shouldn't be needed.
File src/mainboard/microtech/etabpro/bootblock.c:
Patch Set #4, Line 31: mainboard_ec_init();
This isn't needed for now.
File src/mainboard/microtech/etabpro/chromeos.c:
Not going to use chromeos
File src/mainboard/microtech/etabpro/dsdt.asl:
Patch Set #4, Line 32: /* CPU */
I would remove this comment, it is of no use.
/* Chrome OS specific */
#include <vendorcode/google/chromeos/acpi/chromeos.asl>
#include <southbridge/intel/common/acpi/sleepstates.asl>
/* Chrome OS Embedded Controller */
Scope (\_SB.PCI0.LPCB)
{
/* ACPI code for EC SuperIO functions */
#include <ec/google/chromeec/acpi/superio.asl>
/* ACPI code for EC functions */
#include <ec/google/chromeec/acpi/ec.asl>
}
Not going to need this either
File src/mainboard/microtech/etabpro/ec.h:
That's specific to chromeec, should also go away
File src/mainboard/microtech/etabpro/ec.c:
Same here, chromeec specific
File src/mainboard/microtech/etabpro/mainboard.c:
#include <soc/nhlt.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "ec.h"
#include "gpio.h"
More Chromebook-specific code here.
File src/mainboard/microtech/etabpro/nhlt.c:
Not needed for now.
File src/mainboard/microtech/etabpro/smihandler.c:
This should not be needed either.
File src/mainboard/microtech/etabpro/variants.h:
This should not be needed either.
To view, visit change 39219. To unsubscribe, or for help writing mail filters, visit settings.