1 comment:
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #23, Line 154: is_dev_enabled(dev)
SG! ADL is not urgent, this still in early stage. […]
Sorry about the delay Eric. Holidays and some build duties kept me busy, so I couldn't push this up earlier. Here is what I am thinking: CB:48968, CB:48969.
CB:48968 adds a helper function that returns a mask that can be used to set the FSP UPD directly. CB:48969 is an example of what changes would be required at the SoC level. Since we are dealing with both CPU and PCH root ports, at the SoC level, we will need `get_pch_pcie_rp_table()` and `get_cpu_pcie_rp_table()`. And the same helper function in CB:48968 should work just fine. That will allow us to get rid of PCIE_RP_ENABLED flag completely. It also prevents any inconsistent configuration in devicetree i.e. UPD set to enabled but device set to off, etc.
What do you think?
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.