Patch Set 2:

Patch Set 2:

Yeah, the whole IT85xx line seems to be ECs. We have some in
`ec/<possible firmware vendor>/it85*`. Their PnP interface seems
to be independent from the programmable part, though. So maybe
treating the interfaces separately would be feasible in this case.

We can't share the EC firmware interface parts ofc, but we could
share the PnP definitions. Though, if this is going to be another
driver that doesn't make this distinction (and gets firmware
interface parts added later), it should probably reside in `ec/`.

Ok, yes, it seems to make sense to split those parts then.

Oh, I didn't know that there's IT85xx support already.

The EC is mostly independent of the SuperIO configuration as it has it's own address space.
Looks like a good idea to place it in ec/

View Change


To view, visit change 30957. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72aa756e123d6f99d9ef4fe955c4b7f1be25d547
Gerrit-Change-Number: 30957
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <>
Gerrit-Reviewer: Felix Held <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Philipp Deppenwiese <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Nico Huber <>
Gerrit-Comment-Date: Thu, 17 Jan 2019 08:04:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <>
Gerrit-MessageType: comment