11 comments:
File src/mainboard/google/hatch/romstage_spd_smbus.c:
This should probably return a CB_ERR value and that can be used down on line 123.
Done
unsigned
Done
SPD
Done
Please use CB_ERR and friends.
Done
Patch Set #2, Line 56: *spd_cache = rdev_mmap_full(&rdev);
Shouldn't you check the CRC above to make sure the cache is valid? The update_spd_cache() can fail a […]
In new patchset, there is a function called spd_cache_is_valid, it can use to check if the data is valid.
Patch Set #2, Line 64: BIOS_DEBUG
BIOS_INFO fits better in my opinion.
Done
unsigned int
Done
Patch Set #2, Line 97: BIOS_INFO
BIOS_WARN
Done
last system boot
Done
Patch Set #2, Line 109: BIOS_INFO
BIOS_NOTICE
Done
File src/mainboard/google/hatch/romstage_spd_smbus.c:
== 0 […]
In new patchset, it changed to sn == 0xffffffff when dimm is not present.
To view, visit change 40415. To unsubscribe, or for help writing mail filters, visit settings.