Felix Singer submitted this change.

View Change

Approvals: Patrick Rudolph: Looks good to me, approved Janik Haag: Looks good to me, but someone else must approve Kevin Keijzer: Looks good to me, but someone else must approve build bot (Jenkins): Verified
mb/asrock/b75m-itx: Use chipset dt reference names

Use the references from the chipset devicetree as this makes the
comments superfluous.

Change-Id: I369ae1fd66326a2cbfa3fe155b0118251e2272d9
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79971
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kevin Keijzer <kevin@quietlife.nl>
Reviewed-by: Janik Haag
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
M src/mainboard/asrock/b75m-itx/devicetree.cb
1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/src/mainboard/asrock/b75m-itx/devicetree.cb b/src/mainboard/asrock/b75m-itx/devicetree.cb
index 6d4ca2d..59645f0 100644
--- a/src/mainboard/asrock/b75m-itx/devicetree.cb
+++ b/src/mainboard/asrock/b75m-itx/devicetree.cb
@@ -7,13 +7,13 @@
register "spd_addresses" = "{0x50, 0, 0x52, 0}"

device domain 0 on
- device pci 00.0 on
+ device ref host_bridge on
subsystemid 0x1849 0x0150
end
- device pci 01.0 on
+ device ref peg10 on
subsystemid 0x1849 0x0151
end
- device pci 02.0 on
+ device ref igd on
subsystemid 0x1849 0x0152
end
chip southbridge/intel/bd82x6x
@@ -28,42 +28,42 @@
register "spi_uvscc" = "0x2005"
register "spi_lvscc" = "0x2005"

- device pci 14.0 on # USB 3.0 Controller
+ device ref xhci on
subsystemid 0x1849 0x1e31
end
- device pci 16.0 on # Management Engine Interface 1
+ device ref mei1 on
subsystemid 0x1849 0x1e3a
end
- device pci 16.1 off end # Management Engine Interface 2
- device pci 16.2 off end # Management Engine IDE-R
- device pci 16.3 off end # Management Engine KT
- device pci 19.0 off end # Intel Gigabit Ethernet
- device pci 1a.0 on # USB2 EHCI #2
+ device ref mei2 off end
+ device ref me_ide_r off end
+ device ref me_kt off end
+ device ref gbe off end
+ device ref ehci2 on
subsystemid 0x1849 0x1e2d
end
- device pci 1b.0 on # HDA Audio controller
+ device ref hda on
subsystemid 0x1849 0x8892
end
- device pci 1c.0 on # PCIe Port #1
+ device ref pcie_rp1 on
subsystemid 0x1849 0x1e10
end
- device pci 1c.1 off end # PCIe Port #2
- device pci 1c.2 off end # PCIe Port #3
- device pci 1c.3 on # PCIe Port #4, Realtek PCIe GbE Controller
+ device ref pcie_rp2 off end
+ device ref pcie_rp3 off end
+ device ref pcie_rp4 on # Realtek PCIe GbE Controller
subsystemid 0x1849 0x1e16
device pci 00.0 on end # PCI 10ec:8168
end
- device pci 1c.4 off end # PCIe Port #5
- device pci 1c.5 on # PCIe Port #6
+ device ref pcie_rp5 off end
+ device ref pcie_rp6 on
subsystemid 0x1849 0x1e1a
end
- device pci 1c.6 off end # PCIe Port #7
- device pci 1c.7 off end # PCIe Port #8
- device pci 1d.0 on # USB2 EHCI #1
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
+ device ref ehci1 on
subsystemid 0x1849 0x1e26
end
- device pci 1e.0 off end # PCI bridge
- device pci 1f.0 on # LPC bridge
+ device ref pci_bridge off end
+ device ref lpc on
subsystemid 0x1849 0x1e49
chip superio/nuvoton/nct6776
device pnp 2e.0 off end # Floppy
@@ -117,14 +117,14 @@
end
end
end
- device pci 1f.2 on # SATA Controller 1
+ device ref sata1 on
subsystemid 0x1849 0x1e02
end
- device pci 1f.3 on # SMBus
+ device ref smbus on
subsystemid 0x1849 0x1e22
end
- device pci 1f.5 off end
- device pci 1f.6 off end # Thermal
+ device ref sata2 off end
+ device ref thermal off end
end
end
end

To view, visit change 79971. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I369ae1fd66326a2cbfa3fe155b0118251e2272d9
Gerrit-Change-Number: 79971
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Janik Haag
Gerrit-Reviewer: Kevin Keijzer <kevin@quietlife.nl>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged