Felix Singer submitted this change.

View Change

Approvals: Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Martin L Roth: Looks good to me, approved
mb/google/puff: Hide LSPCON device from Windows

Puff-based Chromeboxes use a LSPCON for HDMI 2.0 output, but no driver
exists or is needed for Windows. Use the devicetree hidden keyword to
set the ACPI status to hidden for these devices, to prevent unknown
devices from being listed in Windows Device Manager.

TEST=build/boot Win11 on google/wyvern, verify no unknown devices in
Windows Device Manager for either LSPCON device.

Change-Id: Ib646e01a337b8d7baf20a886c49a8cb64d6408f3
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78040
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
---
M src/mainboard/google/puff/variants/ambassador/overridetree.cb
M src/mainboard/google/puff/variants/duffy/overridetree.cb
M src/mainboard/google/puff/variants/faffy/overridetree.cb
M src/mainboard/google/puff/variants/genesis/overridetree.cb
M src/mainboard/google/puff/variants/kaisa/overridetree.cb
M src/mainboard/google/puff/variants/moonbuggy/overridetree.cb
M src/mainboard/google/puff/variants/noibat/overridetree.cb
M src/mainboard/google/puff/variants/puff/overridetree.cb
M src/mainboard/google/puff/variants/wyvern/overridetree.cb
9 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/mainboard/google/puff/variants/ambassador/overridetree.cb b/src/mainboard/google/puff/variants/ambassador/overridetree.cb
index 5a1002a..12fcfdb 100644
--- a/src/mainboard/google/puff/variants/ambassador/overridetree.cb
+++ b/src/mainboard/google/puff/variants/ambassador/overridetree.cb
@@ -354,7 +354,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -363,7 +363,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/duffy/overridetree.cb b/src/mainboard/google/puff/variants/duffy/overridetree.cb
index 27768df..38752d2 100644
--- a/src/mainboard/google/puff/variants/duffy/overridetree.cb
+++ b/src/mainboard/google/puff/variants/duffy/overridetree.cb
@@ -413,7 +413,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -422,7 +422,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/faffy/overridetree.cb b/src/mainboard/google/puff/variants/faffy/overridetree.cb
index d024043..3bfb9b4 100644
--- a/src/mainboard/google/puff/variants/faffy/overridetree.cb
+++ b/src/mainboard/google/puff/variants/faffy/overridetree.cb
@@ -387,7 +387,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -396,7 +396,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/genesis/overridetree.cb b/src/mainboard/google/puff/variants/genesis/overridetree.cb
index 2ec3aa1..e2f3fde 100644
--- a/src/mainboard/google/puff/variants/genesis/overridetree.cb
+++ b/src/mainboard/google/puff/variants/genesis/overridetree.cb
@@ -384,7 +384,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -393,7 +393,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/kaisa/overridetree.cb b/src/mainboard/google/puff/variants/kaisa/overridetree.cb
index 3e71aa4..7c4ca92 100644
--- a/src/mainboard/google/puff/variants/kaisa/overridetree.cb
+++ b/src/mainboard/google/puff/variants/kaisa/overridetree.cb
@@ -413,7 +413,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -422,7 +422,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb
index aa2377e..95f6965 100644
--- a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb
+++ b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb
@@ -386,7 +386,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -395,7 +395,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/noibat/overridetree.cb b/src/mainboard/google/puff/variants/noibat/overridetree.cb
index 0986048..9fb8587 100644
--- a/src/mainboard/google/puff/variants/noibat/overridetree.cb
+++ b/src/mainboard/google/puff/variants/noibat/overridetree.cb
@@ -324,7 +324,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -333,7 +333,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/puff/overridetree.cb b/src/mainboard/google/puff/variants/puff/overridetree.cb
index 349740c..e7f4a51 100644
--- a/src/mainboard/google/puff/variants/puff/overridetree.cb
+++ b/src/mainboard/google/puff/variants/puff/overridetree.cb
@@ -348,7 +348,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -357,7 +357,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on
diff --git a/src/mainboard/google/puff/variants/wyvern/overridetree.cb b/src/mainboard/google/puff/variants/wyvern/overridetree.cb
index 89530f3..8adbb5c 100644
--- a/src/mainboard/google/puff/variants/wyvern/overridetree.cb
+++ b/src/mainboard/google/puff/variants/wyvern/overridetree.cb
@@ -349,7 +349,7 @@
register "hid" = ""1AF80175""
register "name" = ""PS17""
register "desc" = ""Parade PS175""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c3 on
@@ -358,7 +358,7 @@
register "hid" = ""10EC2142""
register "name" = ""RTD2""
register "desc" = ""Realtek RTD2142""
- device i2c 4a on end
+ device i2c 4a hidden end
end
end
device ref i2c4 on

To view, visit change 78040. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib646e01a337b8d7baf20a886c49a8cb64d6408f3
Gerrit-Change-Number: 78040
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: CoolStar <coolstarorganization@gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-MessageType: merged