3 comments:
File tests/include/lib/edid-test.h:
Patch Set #2, Line 7: struct edid_raw {
Shouldn't this be in src/include/edid.h?
cmocka_unit_test(test_decode_edid_frame_1),
cmocka_unit_test(test_decode_edid_frame_2),
cmocka_unit_test(test_decode_edid_frame_3),
Can you name the test cases in a different way? test_device_edid_frame_2 and test_device_edid_frame_3 have one extension, but test_device_edid_frame_1 doesn't, so you're testing the correct handling of an extension in test_device_edid_frame_2, but how are test_device_edid_frame_2 and test_device_edid_frame_3 different?
Patch Set #2, Line 22: //return 0;
nit: please remove commented-out code
To view, visit change 46817. To unsubscribe, or for help writing mail filters, visit settings.