Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Subrata Banik, Michael Niewöhner, EricR Lai.
Patch set 54:Code-Review +1
3 comments:
Patchset:
Change looks okay to me. It would be good if Subrata/Meera can provide some clarification on the "free running" clock configuration.
File src/mainboard/intel/adlrvp/devicetree.cb:
I did that on brya. I leave here to the Intel. […]
SGTM
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
Patch Set #47, Line 22: PCIE_RP_CLK_FREE = (1 << 3),
Done
But, it is still not clear.
Configuration 1: For a root port, a clock source would be always on and there is no CLKREQ# associated with it. This is determined by PCIE_RP_CLK_REQ_UNUSED.
Configuration 2: For a root port, a clock source provided by the SoC is not used. This is determined by PCIE_RP_CLK_SRC_UNUSED.
Configuration 3: For a root port, a clock source is assigned, but it is considered as "free running", which I think means clock source would be always on and there is no CLKREQ# associated with it. So how is this different than configuration 1 above?
Subrata/Meera - any inputs on this?
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.