4 comments:
Patch Set #5, Line 7: soc/intel/common/block
@Furquan see https://review.coreboot. […]
@Furquan, please look at https://review.coreboot.org/c/coreboot/+/45541/1, its taken care
File src/soc/intel/common/basecode/reset/Makefile.inc:
Patch Set #8, Line 4: endif
postcar being such a thin stage, do we see any scope for global reset. so far reset. […]
Ack
File src/soc/intel/common/basecode/reset/reset.c:
Patch Set #8, Line 11: do_global_reset
well, IMHO that should be reworded, too :S see what I wrote here https://review.coreboot. […]
Ack
Patch Set #8, Line 22: /* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */
I might be weird, but I like to have a comment explaining why `do_full_reset` doesn't do a full rese […]
Ack
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.