Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40369 )
Change subject: nb/i945: Drop unneeded loop ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3: Code-Review-1
Removing code that you don't fully understand is a surefire way to break things. Don't forget that some registers directly control hardware states, and some other registers (e.g. SCIP on ICH7) can even be changed by the hardware itself!
Indeed, I don't understand...! I've asked to test on IRC, isn't it ? I've tested current on my board (desktop version) and I've checked, apple/macbook21 vendore did the same.
So please teach me why we have this loop ? Thx
I've just checked and this hasn't been touched since it was added. It would be nice to know why, but I guess we will never know...