View Change

2 comments:

• File trace.c:

  • Patch Set #1, Line 210:

                                    /* Special commands */
                                    switch (spi_command) {
                                    case 0xb7:
                                            address_mode = 4;
                                            break;
                                    case 0xe9:
                                            address_mode = 3;
                                            break;
                                    }
    

    Huh, this part is indented with spaces

    Done

  • Patch Set #1, Line 224:

    if (address_mode == 3)
    						address = (data[i * 8 + 5] << 16) + (data[i * 8 + 6] << 8) + data[i * 8 + 7];
    					else
    						address = (data[i * 8 + 5] << 24) + (data[i * 8 + 6] << 16) + (data[i * 8 + 7] << 8) + data[i * 8 + 8];
    

    How about: […]

    Besides the off by one error there, I'm not sure that this contributes to the readability of the code, although it is kind of neat. I had it in there and removed it again, for now.

To view, visit change 48553. To unsubscribe, or for help writing mail filters, visit settings.