Patch Set 5:
> >
> However, it's okay to drop the boards which seem to be really broken (switching away from ROMCC_BOOTBLOCK is not enough)
>
> amd/bettong
> amd/db-ft3b-lc
> amd/lamar
> amd/olivehillplus
> bap/ode_e21XX

all of those boards are not unmaintained and not tested ...

Your -1 (or even -2) is ok, so why those uploads/rebase ?

This code could be useful while programming for the other boards (i.e. there are some references), and always a chance someone will appear after a few months to test. I saw a used biostar/a68n_5200 somewhere, although its' CPU is just A6 instead of A10 and a bit inefficient to buy this board just for the purpose of testing. But maybe someone who already has this board, will learn about coreboot one day, test this board and maybe also contribute some common coreboot code all the boards could benefit from.

Your latest patchset 6 removes only amd/bettong for some reason; I think it's also okay to remove amd/db-ft3b-lc , amd/lamar , amd/olivehillplus , bap/ode_e21XX - like it was in patchset 5. I tried to switch away these boards at CB:37981 , CB:37980 , CB:37979 , CB:37976 but failed because they have the other problems.

View Change

To view, visit change 37997. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If129044a44df364a55d10a56e9a678212516ed8a
Gerrit-Change-Number: 37997
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 02 Jan 2020 08:40:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment