13 comments:
File Documentation/drivers/smmstorev2.md:
Patch Set #14, Line 17: unformated
unformatted
used,
Patch Set #14, Line 68: assuptions
assumptions
in
Patch Set #14, Line 123: to write
writing
Patch Set #14, Line 124: meanful
meaningful
Patch Set #14, Line 144: to write
writing
Patch Set #14, Line 165: to clear
clearing
File src/drivers/smmstore/store.c:
APM
Patch Set #14, Line 416: if (offset >= region_device_sz(&com_buf)) {
nit: blank line after if
Patch Set #14, Line 425: ptr = rdev_mmap(&com_buf, offset, bufsize);
nit: blank line after if
Patch Set #14, Line 430: ret = rdev_writeat(&store, ptr, 0, bufsize);
nit: blank line after if
Patch Set #14, Line 450: // NOTE: Not really necessarry..
agreed, none of the other functions check this so either they all should or none.
I think it's okay to be a little extra paranoid in SMM. Maybe all of the exported functions should check for store_initialized?
To view, visit change 40520. To unsubscribe, or for help writing mail filters, visit settings.