Patch set 1:
Patch Set #1, Line 7:
src/arch: This is an upgrade of SMBIOS to latest version 3.2
Please use a verb in imperative mood, cf `git log --oneline` for how to word git commit summaries.
smbios: Add and adapt fields for version 3.2
This is the second of 2 patches upgrading the SMBIOS interface to the latest 3.2
First patch is in mosys. Newer required fields are added to various types definitions
Please add dots to the end of sentences.
Better reference the commit by hash and commit message summary, if it has been submitted/committed already.
Please elaborate more about the change. Thread counts on so on.
Patch Set #1, Line 570:
!(leaf_b.eax | leaf_b.ebx | leaf_b.ecx | leaf_b.edx))
Please indent the condition.
To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.