Patch Set 1:

Could we do this at the SOC level?

If we had a Kconfig entry in the SOC that allowed the mainboard to define an HDA codec device ID then the SOC level code could have this structure (filled with CONFIG_SUBSYSTEM_VENDOR_ID and something like CONFIG_HDA_CODEC_ID) and pass it to FSP if HDA is enabled.

Done, moved to SOC level and add HDA_CODEC_ID

View Change

To view, visit change 29651. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao <>
Gerrit-Reviewer: Jairaj Arava <>
Gerrit-Reviewer: Krzysztof M Sywula <>
Gerrit-Reviewer: Lijian Zhao <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Pratikkumar V Prajapati <>
Gerrit-Reviewer: Sathyanarayana Nujella <>
Gerrit-Reviewer: Subrata Banik <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Duncan Laurie <>
Gerrit-Comment-Date: Fri, 30 Nov 2018 23:49:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment