Attention is currently required from: Martin Roth, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: [WIP]drivers/efi: Add UEFI variable store option support ......................................................................
Patch Set 1:
(9 comments)
File src/drivers/efi/option.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/f86360cb_531325f4 PS1, Line 13: if (!smmstore_lookup_region(&rdev)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/a8ef1cd5_33b64815 PS1, Line 22: if (!smmstore_lookup_region(&rdev)) { braces {} are not necessary for single statement blocks
File src/include/option.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/c216644e_c363be2f PS1, Line 34: if (CONFIG(USE_OPTION_TABLE)) { suspect code indent for conditional statements (8, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/0e6c9ece_99f27169 PS1, Line 35: if (cmos_get_option(&value, name) == CB_SUCCESS) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/0e02b83d_822aaa9b PS1, Line 35: if (cmos_get_option(&value, name) == CB_SUCCESS) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/64101e31_ff6bc024 PS1, Line 35: if (cmos_get_option(&value, name) == CB_SUCCESS) suspect code indent for conditional statements (15, 38)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/e7c42970_07695b72 PS1, Line 36: return value; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/a1bde82f_53e5e9e5 PS1, Line 36: return value; Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117452): https://review.coreboot.org/c/coreboot/+/52564/comment/fa6e7bb4_db211794 PS1, Line 40: if(efi_smmstore_get_option(name, (void **)&value, &size) == CB_SUCCESS) { space required before the open parenthesis '('