Attention is currently required from: Bao Zheng, Raul Rangel.
6 comments:
Commit Message:
Patch Set #30, Line 7: Use *number in config file
Why is this needed? What's the purpose?
Patch Set #30, Line 10: XXXX_FW_TYPE_STRING *0xXXXXX
Why not just use commas to separate them?
Add BUG= and TEST=?
File util/amdfwtool/data_parse.c:
else if (strcmp(fw_name, "AMD_PUBKEY_FILE") == 0) {
fw_type = AMD_FW_PSP_PUBKEY;
subprog = 0;
Nit: Not related to this patch, but it seems like the simple matches like this could be put into a data structure instead of having quite so many else if statements.
Maybe look at that for a future patch?
These if statements are getting deep. Maybe break them out to separate functions?
Nit: Obviously not this patch, but 6 levels of if and while statements is pretty deep. Could this be refactored into a separate function?
Again, maybe a future patch?
To view, visit change 49015. To unsubscribe, or for help writing mail filters, visit settings.