Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
device/azalia_device.h: Guard macro parameters

Add parentheses around macro parameters to avoid operation order issues.

Change-Id: Ic984a82da5eb31fc2921cff3265ac5ea2be098c7
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58900
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/include/device/azalia_device.h
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h
index 9010507..ca77350 100644
--- a/src/include/device/azalia_device.h
+++ b/src/include/device/azalia_device.h
@@ -136,7 +136,7 @@
(((codec) << 28) | ((pin) << 20) | (0x71f << 8) \
| (((val) >> 24) & 0xff))

-#define AZALIA_PIN_CFG_NC(n) (0x411111f0 | (n & 0xf))
+#define AZALIA_PIN_CFG_NC(n) (0x411111f0 | ((n) & 0xf))

#define AZALIA_RESET(pin) \
(((pin) << 20) | 0x7ff00), (((pin) << 20) | 0x7ff00), \

To view, visit change 58900. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic984a82da5eb31fc2921cff3265ac5ea2be098c7
Gerrit-Change-Number: 58900
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged