Attention is currently required from: Angel Pons, Michael Büchler, Michael Niewöhner, Michał Żygowski, Máté Kukri, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port ......................................................................
Patch Set 30:
(6 comments)
File src/mainboard/dell/optiplex_9020/Kconfig:
https://review.coreboot.org/c/coreboot/+/55232/comment/f61388b9_6f967d4c : PS30, Line 22: hex Symbol type is not necessary as it is defined in the src/Kconfig
https://review.coreboot.org/c/coreboot/+/55232/comment/a634d5dd_b39cf7ec : PS30, Line 26: string Symbol type not necessary
https://review.coreboot.org/c/coreboot/+/55232/comment/9c300dfa_497a9afa : PS30, Line 30: string Symbol type not necessary
File src/mainboard/dell/optiplex_9020/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/55232/comment/25d850b9_96ab9835 : PS30, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ Should be ``` /* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */ ``` for otherwise empty files. Refer to commit cf4722d317
File src/mainboard/dell/optiplex_9020/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/55232/comment/2d9e0561_c0024a24 : PS30, Line 1: GPL-2.0-only CC-PDDC, see my comment on ec.asl
File src/mainboard/dell/optiplex_9020/overridetree_mt.cb:
https://review.coreboot.org/c/coreboot/+/55232/comment/86ea1225_a37b605c : PS30, Line 6: birdge bridge