Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Held, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, Shuo Liu, TangYiwei, Tim Chu.

View Change

2 comments:

• File src/soc/intel/xeon_sp/chip_gen6.c:

  • Patch Set #56, Line 56: res->flags = IORESOURCE_IO | IORESOURCE_SUBTRACTIVE | IORESOURCE_ASSIGNED;

    Good suggestion! Updated.

    Well, this is the domain level where we describe the windows available for
    allocation. It's probably just coincidence that it matches in position and
    size what we usually tag fixed.

    There are two things:
    1. Xeon-SP hardware always forwards (or is configured by FSP to always forward) this, iow. makes it available for anything below DMI I guess (not fixed. maybe subtractive maybe not, doesn't matter to the resource allocator).
    2. Developers are lazy and instead of adding all the "Fixed I/O Ranges Decoded by PCH" (table usually found it PCH datasheets) individually, we add a bulk 0..fff fixed resource, traditionally to the LPC/eSPI device as representative for all the legacy things in a PCH.

    Now, 2. is already done in common/block/lpc code.

• File src/soc/intel/xeon_sp/gnr/Kconfig:

  • Patch Set #56, Line 17: select FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND

    GNR still needs this ... the related discussion history is at: […]

    That's why we do open-source, right? Because things that take a month or
    two in open-source take years in proprietary projects.

To view, visit change 81316. To unsubscribe, or for help writing mail filters, visit settings.