Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
mb/google/volteer/variants/terrador: Enable Cmd Mirror

Enable CmdMirror for Terrador to achieve optimum routing from SoC to
DRAMs

BUG=b:156435028
BRANCH=none
TEST=FW_NAME=terrador emerge-volteer coreboot chromeos-bootimage

Signed-off-by: David Wu <david_wu@quanta.corp-partner.google.com>
Change-Id: I0db9fff0dddf35c99a6cb2a90d40886ed8e18686
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42274
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
---
M src/mainboard/google/volteer/variants/terrador/overridetree.cb
1 file changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
index 4bff10d..81da6bd 100644
--- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
@@ -1,4 +1,9 @@
chip soc/intel/tigerlake
+ # BitMask where bits [3:0] are Controller 0 Channel [3:0] and
+ # bits [7:4] are Controller 1 Channel [3:0].
+ # Enable Command Mirroring for controller 0 channel 0 and 1,
+ # and controller 1 channel 0 and 1.
+ register "CmdMirror" = "0x00000033"
device domain 0 on
device pci 15.1 on
chip drivers/i2c/hid

To view, visit change 42274. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0db9fff0dddf35c99a6cb2a90d40886ed8e18686
Gerrit-Change-Number: 42274
Gerrit-PatchSet: 10
Gerrit-Owner: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang@intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kane Chen <kane.chen@intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged