Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.

View Change

2 comments:

• File src/arch/x86/smbios.c:

  • Patch Set #1, Line 1223: } else {

    Sorry, I mixed that up a little. Your change is sound, just the […]

    I see. I would've expected that disabled devices are never found here, though. But yes, skipping disabled devices makes sense.

    So, should I make a patch that skips disabled devices?

  • Patch Set #1, Line 1225: len += smbios_generate_type41_from_devtree(dev, handle, current);

    Instead of exposing these as API, we'd usually have a default get_smbios_data() that […]

    Sounds good.

To view, visit change 57366. To unsubscribe, or for help writing mail filters, visit settings.