2 comments:
File src/soc/intel/cannonlake/uart.c:
Patch Set #1, Line 53: struct device *soc_uart_console_to_device(int uart_console)
Use DEVTREE_CONST here
The type cast below was to drop the const qualifier. If I add the const qualifier here, then the related chain of functions also needs to be updated to align to updated return type. i.e uart_get_device and its consumers, including the ramstage common acpi driver. Plus, I don't see the functions manipulating the value returned by soc_uart_console_to_device and merely consuming it for the device reference. Please let me know if you see a risk.
File src/soc/intel/common/block/uart/uart.c:
Patch Set #1, Line 75: pci_devfn_t dev = PCI_DEV(0, PCI_SLOT(devfn), PCI_FUNC(devfn));
Should be: […]
I tried replacing it with PCI_BDF, seems the pcidev_assert is not available in simple device environment. guess will have to stick with PCI_DEV, thoughts?
To view, visit change 34582. To unsubscribe, or for help writing mail filters, visit settings.