I think there's some misunderstanding about what happened here, Nico... sounds like you think we just loosened the linter a bit for those truly exceptional cases the coding style allows, but I think everyone else (e.g. Patrick) thinks the new default limit for everything is now 96. That's what I'm opposed to. (Note that CB:31771 also just changed the coding style documentation.)

I am not saying that you may never ignore the linter if you have a truly exceptional case where everyone agrees not breaking lines helps readability. Many of our linter warnings have occasional false positives that we intentionally ignore anyway, and that's fine. As I said, if you want to clarify the warning text to point out the possibility of rare exceptions, I think that would be okay. (I do thing we should have some sort of warning for the default limit, though, just because it helps a lot with catching mistakes.)

But I am strongly opposed to changing the default limit and I think such a sweeping and controversial change should absolutely not be made the way it was made here.

View Change

To view, visit change 31651. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9293a69d1bea900da36501cde512004d0695ad37
Gerrit-Change-Number: 31651
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Sat, 09 Mar 2019 00:10:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment