Patch Set 2:

(4 comments)

Subrata, I just realized that a choice doesn't work
well if one wants to select a specific option from
the mainboard Kconfig. Currently, intel/saddlebrook
does that. I'm not sure if that's necessary.

Do you think we need to be able to select things or
should it be always up to the person that configures
coreboot? If the latter, the choice makes sense,
otherwise it would get too complex, I fear.

[Subrata] I think this is better option "we need to be able to select things"
choice might be easy to understand but select makes more sense from SOC

View Change

To view, visit change 33361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a7490948f729f1ae9fd2537bf6cbe9ada51f968
Gerrit-Change-Number: 33361
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 10 Jun 2019 10:57:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment