Attention is currently required from: Derek Huang, Brandon Breitenstein, Curtis Chen.

View Change

3 comments:

• File src/mainboard/google/volteer/mainboard.c:

  • Patch Set #9, Line 155: if ((ret = google_chromeec_usb_get_pd_mux_info(port, &mux_flags)) < 0)

    Maybe can rephrase to:

    ret = google_chromeec_usb_get_pd_mux_info(port, &mux_flags);
    if ( ret != 0) { 
        ...
        return ret;
    }

  • Patch Set #9, Line 161: /* If port is connected */

    Do you mean the mux_flags is not empty then the port is connected? The mux_flags is used to return the mux_state, do you need to check the state to make sure the port is connected?

• File src/soc/intel/common/block/tcss/tcss.c:

  • Patch Set #9, Line 296: WAIT_FOR_DISPLAYPORT_TIMEOUT

    If there are 3 typec ports and if the port 0, 1 don't connect the external display and port2 connects the external display, we will need around 3 * WAIT_FOR_DISPLAYPORT_TIMEOUT + WAIT_FOR_HPD_TIMEOUT = 6 second to light up the dev screen in the worst case right?

To view, visit change 57139. To unsubscribe, or for help writing mail filters, visit settings.