Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41440 )
Change subject: sconfig: Add support for firmware configuration ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41440/5/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/41440/5/util/sconfig/main.c@336 PS5, Line 336: if (!strncmp(option->name, name, strlen(name))) In fact, these too are odd (see below) and finding anything that matches the prefix 'name'. Why not just strcmp()?
https://review.coreboot.org/c/coreboot/+/41440/5/util/sconfig/main.c@401 PS5, Line 401: && field->name I don't think it's possible for field->name to be NULL here?
https://review.coreboot.org/c/coreboot/+/41440/5/util/sconfig/main.c@451 PS5, Line 451: use length of new name to allow existing as prefix Effectively this just means you're forbidding the new name from being a prefix of any existing one. Is that intentional? I think we just care about the full name being unique so I think you should just want a plain old strcmp() here?