Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... Patch Set 3:
Patch Set 3: -Code-Review
The change on its own looks good, but I'm worried about the impact on updates since that changes the fmap layout. Do we really need this additional space? what for?
The size of qc_sec.mbn has increased with recent changes. Since qc_sec is merged with bootblock, this additional space is needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 3 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 17 Jun 2019 07:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment