Attention is currently required from: Elyes Haouas, Felix Singer, Jakub Czapiga, Martin L Roth, Maximilian Brune, Nico Huber.

Patch set 26:Code-Review +2

View Change

1 comment:

• File src/include/stddef.h:

  • Patch Set #26, Line 25: #define nullptr ((void *)0)

    I also don't think people are against using it. […]

    I don't remember exactly what was said but I agree with Felix here: I think the important part is that we don't want to rewrite existing code and keep using NULL by default in new code. But I'm okay with adding these definitions here and resolving NULL to nullptr when available for whatever tiny type-checking advantage that may bring. Having the name nullptr defined may be useful in rare cases where we're importing code wholesale from somewhere that uses it, although I don't think we should start using it in normal coreboot code.

To view, visit change 83459. To unsubscribe, or for help writing mail filters, visit settings.