Felix Held submitted this change.
soc/amd/common/espi_util: clarify espi_open_io_window
Calling espi_open_generic_io_window in espi_open_io_window depends on
the condition in the preceding if statement, so move the command into an
else block to make it more obvious that this is the case.
TEST=Timeless build results in identical image.
Change-Id: I3039817afd79c30a2df2f2f54e7848f52dc2c487
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44353
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
---
M src/soc/amd/common/block/lpc/espi_util.c
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c
index 1b617fc..0878fb7 100644
--- a/src/soc/amd/common/block/lpc/espi_util.c
+++ b/src/soc/amd/common/block/lpc/espi_util.c
@@ -183,9 +183,9 @@
if (std_io != -1) {
espi_enable_decode(std_io);
return 0;
+ } else {
+ return espi_open_generic_io_window(base, size);
}
-
- return espi_open_generic_io_window(base, size);
}
static int espi_find_mmio_window(uint32_t win_base)
To view, visit change 44353. To unsubscribe, or for help writing mail filters, visit settings.