LGTM after resolving outstanding comments
Patch set 10:Code-Review +2
9 comments:
Patch Set #3, Line 7: sc7180: Add support for sn65dsi86 bridge.
Please remove the dot/period at the end of the commit message.
Done
Patch Set #10, Line 7: Sc7180
All other prefixes use lowercase.
still outstanding
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
Why? I'm not aware of any rules on signedness either (unless we're doing MISRA now... […]
Assuming resolved.
unsigned int
Assuming resolved.
unsigned int?
Assuming resolved.
Patch Set #3, Line 248: printk(BIOS_ERR, "ERROR: valid dp rate not found");
Display doesn't work, probably? […]
Assuming resolved.
Patch Set #3, Line 291: printk(BIOS_ERR, "ERROR: PLL lock failure\n");
Display will not work
Assuming resolved.
Patch Set #3, Line 310: printk(BIOS_ERR, "ERROR: Link training failed");
Yes , Display will not work
Assuming resolved.
Then let's wait 400ms instead of 360ms? […]
still outstanding (if the datasheet says 400 we should use 400, right?)
To view, visit change 42899. To unsubscribe, or for help writing mail filters, visit settings.